Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client: calculate commps for pieces bigger than 32GB #8179

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

arajasek
Copy link
Contributor

Related Issues

A user pointed out on Slack that trying to make a deal with a 64GB SP with piece size of 55GB fails

lotus client deal bafykbzacedpyjxesatqb7s4ltsdcfldupqjpqepahxsthgkcdtsa7f3ldlcb4 t031080 0 518400
ERROR: failed to start deal: computing commP failed: commpWriter.Sum failed: generating unsealed CID: Piece is larger than sector.

Proposed Changes

I think it is safe to just assume the largest supported sector size here (64 GB) and leave it at that, but I'm not sure.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner February 24, 2022 15:29
Copy link
Contributor

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should have done this from day 1
My bad!

:shipit:

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #8179 (fd8cb44) into master (7c2f653) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8179      +/-   ##
==========================================
- Coverage   39.91%   39.88%   -0.03%     
==========================================
  Files         666      666              
  Lines       72561    72561              
==========================================
- Hits        28962    28943      -19     
- Misses      38556    38575      +19     
  Partials     5043     5043              
Impacted Files Coverage Δ
node/impl/client/client.go 51.31% <0.00%> (ø)
node/modules/mpoolnonceapi.go 34.00% <0.00%> (-10.00%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
miner/miner.go 55.08% <0.00%> (-1.64%) ⬇️
extern/storage-sealing/fsm.go 56.44% <0.00%> (-1.40%) ⬇️
extern/sector-storage/sched.go 84.77% <0.00%> (-0.83%) ⬇️
chain/consensus/filcns/filecoin.go 52.17% <0.00%> (-0.44%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2f653...fd8cb44. Read the comment docs.

@arajasek arajasek merged commit c940727 into master Feb 24, 2022
@arajasek arajasek deleted the asr/comm-p-fix branch February 24, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants