Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:sealing:really-do-it flag for abort upgrade #8181

Merged
merged 1 commit into from Feb 24, 2022

Conversation

ZenGround0
Copy link
Contributor

Related Issues

#8106

Proposed Changes

Adding the flag!

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ZenGround0
Copy link
Contributor Author

I think we might want to back port this into the release but your call @jennijuju

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #8181 (367146f) into master (b8cd154) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8181      +/-   ##
==========================================
- Coverage   39.83%   39.77%   -0.07%     
==========================================
  Files         666      666              
  Lines       72751    72754       +3     
==========================================
- Hits        28981    28935      -46     
- Misses      38730    38772      +42     
- Partials     5040     5047       +7     
Impacted Files Coverage Δ
cmd/lotus-miner/sectors.go 13.98% <0.00%> (-0.04%) ⬇️
extern/sector-storage/worker_tracked.go 79.46% <0.00%> (-7.15%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-1.97%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
extern/sector-storage/sched.go 83.12% <0.00%> (-1.65%) ⬇️
chain/store/store.go 63.00% <0.00%> (-0.67%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8cd154...367146f. Read the comment docs.

@jennijuju jennijuju merged commit d054340 into master Feb 24, 2022
@jennijuju jennijuju deleted the fix/really-do-it-for-abort branch February 24, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants