Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade libp2p to 0.17.0 #8233

Merged
merged 28 commits into from Mar 2, 2022
Merged

Downgrade libp2p to 0.17.0 #8233

merged 28 commits into from Mar 2, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Mar 2, 2022

This is to unblock the Lotus 1.15.0 release until libp2p/go-libp2p#1267 (comment) this is complete. We hope to upgrade to 0.18.0 in Lotus 1.15.1.

This reverts commit 325a4c0.
@arajasek arajasek requested a review from a team as a code owner March 2, 2022 20:44
@vyzo
Copy link
Contributor

vyzo commented Mar 2, 2022

I am making it clear that i will not be redoing that work again; it is your responsibility now.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8233 (ebe1ca7) into release/v1.15.0 (bc5be0c) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.15.0    #8233      +/-   ##
===================================================
+ Coverage            38.99%   39.19%   +0.20%     
===================================================
  Files                  662      660       -2     
  Lines                72189    71915     -274     
===================================================
+ Hits                 28147    28188      +41     
+ Misses               39120    38814     -306     
+ Partials              4922     4913       -9     
Impacted Files Coverage Δ
api/types.go 52.77% <ø> (ø)
cli/net.go 11.42% <ø> (+1.42%) ⬆️
node/builder.go 76.47% <ø> (ø)
node/impl/net/net.go 28.08% <ø> (ø)
node/modules/lp2p/libp2p.go 34.69% <ø> (ø)
itests/kit/ensemble.go 91.24% <100.00%> (ø)
markets/loggers/loggers.go 89.28% <100.00%> (+0.39%) ⬆️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
miner/miner.go 55.40% <0.00%> (-1.97%) ⬇️
lib/rpcenc/reader.go 70.29% <0.00%> (-1.49%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5be0c...ebe1ca7. Read the comment docs.

@arajasek
Copy link
Contributor Author

arajasek commented Mar 2, 2022

@vyzo Redoing what, specifically? We're not dropping this from master, just the February release branch.

@vyzo
Copy link
Contributor

vyzo commented Mar 2, 2022

oh ok, i thought it was master and had a fit; sorry for the tantrum.

@arajasek arajasek merged commit 91d7734 into release/v1.15.0 Mar 2, 2022
@arajasek arajasek deleted the asr/libp2p-downgrade branch March 2, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants