Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: add ArgsUsage field to clientGetDealCmd #8241

Merged
merged 2 commits into from Mar 17, 2022
Merged

fix: cli: add ArgsUsage field to clientGetDealCmd #8241

merged 2 commits into from Mar 17, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Mar 3, 2022

Adds [proposalCID] as ArgsUsage field in the 'lotus client get-deal' command. Fixes #8133

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Adds [proposalCID] as ArgsUsage field in the 'lotus client get-deal' command. Fixes #8133
@rjan90 rjan90 requested a review from a team as a code owner March 3, 2022 14:43
@magik6k
Copy link
Contributor

magik6k commented Mar 3, 2022

Needs make docsgen-cli

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #8241 (3ad1ea3) into master (c98ef0a) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8241      +/-   ##
==========================================
- Coverage   40.39%   40.28%   -0.12%     
==========================================
  Files         679      679              
  Lines       73992    73992              
==========================================
- Hits        29890    29805      -85     
- Misses      38898    38962      +64     
- Partials     5204     5225      +21     
Impacted Files Coverage Δ
cli/client.go 22.23% <ø> (ø)
lib/addrutil/parse.go 75.00% <0.00%> (-15.91%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
miner/warmup.go 71.42% <0.00%> (-4.09%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
miner/miner.go 56.39% <0.00%> (-3.61%) ⬇️
node/modules/core.go 46.46% <0.00%> (-3.04%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-2.44%) ⬇️
... and 21 more

@magik6k magik6k merged commit 7123b29 into filecoin-project:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ArgsUsage field for clientGetDealCmd
2 participants