Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing fsm: Handle inputLk correctly #8291

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 10, 2022

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 10, 2022 19:24
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #8291 (ad66ad4) into master (9fc6242) will decrease coverage by 0.02%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8291      +/-   ##
==========================================
- Coverage   40.32%   40.30%   -0.03%     
==========================================
  Files         679      679              
  Lines       73958    73961       +3     
==========================================
- Hits        29825    29810      -15     
+ Misses      38920    38919       -1     
- Partials     5213     5232      +19     
Impacted Files Coverage Δ
extern/storage-sealing/input.go 53.57% <16.66%> (+1.21%) ⬆️
extern/sector-storage/mock/mock.go 61.32% <80.00%> (+0.70%) ⬆️
storage/wdpost_sched.go 75.49% <0.00%> (-9.81%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
miner/warmup.go 71.42% <0.00%> (-4.09%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
miner/miner.go 56.39% <0.00%> (-2.63%) ⬇️
chain/sub/incoming.go 45.25% <0.00%> (-2.45%) ⬇️
extern/storage-sealing/terminate_batch.go 58.33% <0.00%> (-1.97%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-1.29%) ⬇️
... and 13 more

@magik6k magik6k force-pushed the fix/fsm-input-locking branch 2 times, most recently from 7a28f02 to 801ec62 Compare March 11, 2022 09:38
)

func TestBatchDealInput(t *testing.T) {
t.Skip("this test is disabled as it's flaky: #4611")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't flake in ~30 runs

@arajasek arajasek merged commit 362c73b into master Mar 11, 2022
@arajasek arajasek deleted the fix/fsm-input-locking branch March 11, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants