Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config: Move MakeNewSectorForDeals config into the Sealing sectoin #8378

Merged
merged 1 commit into from Mar 26, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 26, 2022

Proposed Changes

This PR moves MakeNewSectorForDeals into the Sealing section of the config:

  • Dealmaking section is mostly about market side of things, and may even be removed at some point when markets get replaced with boost
  • MakeNewSectorForDeals doesn't really have anything to do with markets

This technically is a breaking change, but it's probably fine to just ship this given that this config wasn't present in any release where it would be actually useful, plus it should be very easy to notice that it has stopped working in case it was used.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 26, 2022 19:57
@magik6k magik6k merged commit 0d7d02d into master Mar 26, 2022
@magik6k magik6k deleted the feat/move-makedealsector-cfg branch March 26, 2022 20:08
@jennijuju jennijuju added this to the v1.15.1 milestone Mar 26, 2022
jennijuju added a commit that referenced this pull request Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants