Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ux: Change Propose-worker msg #8384

Merged
merged 3 commits into from Mar 28, 2022
Merged

fix: ux: Change Propose-worker msg #8384

merged 3 commits into from Mar 28, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Mar 28, 2022

Proposed Changes

Changes the message so its clear that it´s only Storage Providers without active deadlines that needs to call confirm-change-worker.

Fixes: #7498

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Changes the message so it´s clear that it´s only Storage Providers without active deadlines that needs to call 'confirm-change-worker'.
Change what string the TestWorkerKeyChange-test is looking for, to reflect the new Propose-worker msg-changes
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #8384 (e2781ea) into master (caeeb6a) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8384      +/-   ##
==========================================
- Coverage   40.26%   40.19%   -0.07%     
==========================================
  Files         683      683              
  Lines       74480    74480              
==========================================
- Hits        29989    29937      -52     
- Misses      39263    39302      +39     
- Partials     5228     5241      +13     
Impacted Files Coverage Δ
cmd/lotus-miner/actor.go 7.92% <100.00%> (ø)
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.17% <0.00%> (-5.41%) ⬇️
miner/warmup.go 71.42% <0.00%> (-4.09%) ⬇️
miner/miner.go 57.37% <0.00%> (-2.63%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-1.97%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.47%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-1.29%) ⬇️
... and 14 more

@magik6k magik6k merged commit a709a0a into filecoin-project:master Mar 28, 2022
@rjan90 rjan90 deleted the fix/change-worker-msg branch March 29, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confirm-change-worker is not needed to change worker address
2 participants