Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safe piecereader #8397

Merged
merged 1 commit into from Mar 29, 2022
Merged

Thread safe piecereader #8397

merged 1 commit into from Mar 29, 2022

Conversation

aarshkshah1992
Copy link
Contributor

Piecereader in it's current form is NOT thread-safe and we need concurrent access for Bitswap support.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #8397 (d0af0ef) into master (d502eeb) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8397      +/-   ##
==========================================
- Coverage   40.62%   40.57%   -0.06%     
==========================================
  Files         686      686              
  Lines       75333    75343      +10     
==========================================
- Hits        30607    30569      -38     
- Misses      39421    39465      +44     
- Partials     5305     5309       +4     
Impacted Files Coverage Δ
extern/sector-storage/piece_reader.go 63.33% <100.00%> (+4.58%) ⬆️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
extern/sector-storage/faults.go 62.26% <0.00%> (-7.55%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-3.85%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/stmgr/call.go 65.94% <0.00%> (-3.25%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-2.44%) ⬇️
extern/sector-storage/stores/index_locks.go 71.42% <0.00%> (-2.39%) ⬇️
miner/miner.go 56.39% <0.00%> (-1.97%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.17% <0.00%> (-1.81%) ⬇️
... and 15 more

@magik6k magik6k merged commit ba2596e into master Mar 29, 2022
@magik6k magik6k deleted the feat/thread-safe-piecereader branch March 29, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants