feat: View the currently known proving live sectors information #8720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
May 30, 2022
geoff-vball
reviewed
Jun 21, 2022
geoff-vball
reviewed
Jun 21, 2022
cmd/lotus-miner/proving.go
Outdated
Comment on lines
324
to
363
| sectorCount, err := partition.AllSectors.Count() | ||
| sectorCount, err := partition.ActiveSectors.Count() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| sectorNumbers, err := partition.AllSectors.All(sectorCount) | ||
| sectorNumbers, err := partition.ActiveSectors.All(sectorCount) | ||
| if err != nil { |
There was a problem hiding this comment.
Let's add a flag all to this function to give the user the option to get info for AllSectors
There was a problem hiding this comment.
maybe AllSectors is useless to the user
|
@swift-mx Did you push the wrong commit? None of the changes in the latest commit seem to line up with my comments. Let me know if you have any questions :) |
The reason for this PR is that some of our sectors have expired. We want to compress the partitions. But I don't know which one should be compressed. So there is a need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps