refactor: remove old BlockSyncProtocolID #8820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
By now we expect that 100% of nodes will be supporting both protocols, so it should be completely safe to drop the deprecated BlockSync protocol.
However, if we want to be extra sure, we can run a simple DHT and gossipsub/prune based walk to find peers and use identify to verify that 100% of them report both protocols. Might be worth implementing to also have a tool like this for the future.
nit: you can now remove the BlockSyncProtocolID constant.
arajasek
force-pushed
the
asr/deprecate-blocksync
branch
from
1898c5c
to
789f212
Compare
|
@raulk 's nit about removing the BlockSyncProtocolID constant has been addressed |
magik6k
approved these changes
Jun 13, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#3737
Proposed Changes
I think this is safe to do on the live network today, but this is not my strength. Happy to close if there are concerns.
Additional Info
Some more historical context here: #3624 (comment)
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps