Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ci_: Forgot a .sh on the end of a the new publish script #9088

Merged
merged 1 commit into from Jul 27, 2022

Conversation

ianconsolata
Copy link
Contributor

Related Issues

This was discovered to be broken during the v1.17.0-rc4 release:
https://github.com/filecoin-project/lotus/releases/tag/v1.17.0-rc4

Failed build:
https://app.circleci.com/pipelines/github/filecoin-project/lotus/22354/workflows/be8a601c-06eb-4a03-a60e-083d50ff99ee

The release artifacts will be manually published for the RC4 release, but we should cherry pick this commit into the 1.17.0 branch to fix the final release. Good news is that except for the typo, it all works as planned (the AppImage release did publish, even though the other ones failed, which was one of the planned changes).

I'm going to evaluate the snapcraft build failure separately, and publish a separate PR fixing it.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ianconsolata ianconsolata requested a review from a team as a code owner July 27, 2022 15:48
@arajasek
Copy link
Contributor

Ah, that's neat!

The release artifacts will be manually published for the RC4 release, but we should cherry pick this commit into the 1.17.0 branch to fix the final release.

@ianconsolata FYI, you can slap a release/backport label on such PRs -- that's our cue to backport onto the living release branches.

@arajasek arajasek enabled auto-merge July 27, 2022 15:52
@arajasek arajasek merged commit 5046b31 into master Jul 27, 2022
@arajasek arajasek deleted the id/build-arch-bundle.sh branch July 27, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants