Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chain: Update chain.go #9373

Merged
merged 2 commits into from Nov 4, 2022
Merged

Conversation

sectrgt
Copy link
Contributor

@sectrgt sectrgt commented Sep 26, 2022

Related Issues

lotus chain prune does not execute

Proposed Changes

Added ChainPruneCmd to file

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@sectrgt sectrgt requested a review from a team as a code owner September 26, 2022 01:24
@sectrgt sectrgt changed the title Update chain.go fix: chain: Update chain.go Sep 26, 2022
@geoff-vball
Copy link
Contributor

@ZenGround0 You're the one who created the chain prune command. Was the exclusion accidental or on purpose?

@magik6k
Copy link
Contributor

magik6k commented Sep 28, 2022

Thanks for the PR!

CI complains about generated docs - can you run make docsgen-cli and commit changes?

@sectrgt
Copy link
Contributor Author

sectrgt commented Oct 14, 2022

Thanks for the PR!

CI complains about generated docs - can you run make docsgen-cli and commit changes?

Done

@geoff-vball geoff-vball merged commit 54d3e41 into filecoin-project:master Nov 4, 2022
@geoff-vball
Copy link
Contributor

@sectrgt Thanks again for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants