Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add read_into_all method to allow reading of larger parts #34

Closed
wants to merge 2 commits into from

Conversation

dignifiedquire
Copy link

No description provided.

Copy link

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -852,6 +892,14 @@ impl<T: Element, A: Algorithm<T>, K: Store<T>> MerkleTree<T, A, K> {
}
}

pub fn read_into_all(&self, pos: usize, buf: &mut [u8]) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would either then read all of the leaves or the top half, but not both, the all might be a bit misleading here.

@dignifiedquire
Copy link
Author

not needed afterall

@dignifiedquire dignifiedquire deleted the feat/read_into_all branch October 7, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants