Update docker-compose.yml #156
Conversation
Change this, and now it builds correctly. Don't know if this is what you want? ref: #155
| @@ -132,7 +132,7 @@ services: | |||
| - motion-singularity-volume:/usr/src/app/storage | |||
| depends_on: | |||
| singularity_api: | |||
| condition: service_healthy | |||
| condition: service_completed_successfully | |||
There was a problem hiding this comment.
Motion depends on singularity being up and running, not just that it has run. So, it seems like it would be more correct to add a health check to singularity, and keep this as condition: service_healthy
There was a problem hiding this comment.
No I agree, after looking into it more. It showed me for now where the issue was. Thanks
There was a problem hiding this comment.
There is already a /health endpoint to check for health in Singularity
https://github.com/data-preservation-programs/singularity/blob/7a3b2c61c4deb38aea50b6b8bd17a5ab75ff420d/api/api.go#L437C37-L437C37
So something like below
test: curl --fail http://localhost:9090/health || exit 1
interval: 2s
retries: 5
start_period: 2s
timeout: 10s
There was a problem hiding this comment.
Oh that's only available with v0.5.0, below one should work though
http://127.0.0.1:9090/swagger/index.html
Change this, and now it builds correctly. Don't know if this is what you want?
ref: #155