Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Correct when the the current network global var is set #167

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

xinaxu
Copy link
Collaborator

@xinaxu xinaxu commented Oct 18, 2023

The Action for the flag is only executed when the flag is set.
In go-address package, address.CurrentNetwork is initialized to address.Testnet. So we need to check --lotus-test and set it to address.Mainet if the flag is not set.

@xinaxu xinaxu requested a review from masih October 18, 2023 21:55
@codecov-commenter
Copy link

Codecov Report

Merging #167 (5e9c3c1) into main (7230d07) will increase coverage by 0.67%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   30.82%   31.49%   +0.67%     
==========================================
  Files           5        5              
  Lines         743      743              
==========================================
+ Hits          229      234       +5     
+ Misses        479      474       -5     
  Partials       35       35              

see 1 file with indirect coverage changes

@xinaxu xinaxu merged commit 23dd6f7 into main Oct 19, 2023
7 checks passed
@xinaxu xinaxu deleted the xinaxu/testnet-fix branch October 19, 2023 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants