Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODOs from AMT external iterator implementation PR #1925

Closed
jdjaustin opened this issue Nov 16, 2023 · 1 comment
Closed

TODOs from AMT external iterator implementation PR #1925

jdjaustin opened this issue Nov 16, 2023 · 1 comment

Comments

@jdjaustin
Copy link
Contributor

Capturing a couple TODOs from #1912 in a new issue.

TODO(jdjaustin): in another PR: remove or refactor version typestate, and refactor `AmtImpl`
(needs elaboration from @aatifsyed on reasoning and expectations of desired end result)

TODO(aatifsyed): is this guaranteed to be acyclic?
@jdjaustin jdjaustin mentioned this issue Nov 16, 2023
Merged
jdjaustin added a commit that referenced this issue Nov 16, 2023
@jdjaustin
moved TODO comments to issue #1925
b9994df
@Stebalien
Copy link
Member

I'm guessing no action will be taken with respect to this issue, so I'm just going to close it. External iteration works and has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @jdjaustin