Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly convert RegisteredPoStProof type #1750

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

arajasek
Copy link
Collaborator

#1748, but on the release branch

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #1750 (f8c20ab) into release/v3.2 (458262d) will decrease coverage by 19.21%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/v3.2    #1750       +/-   ##
=================================================
- Coverage         74.76%   55.55%   -19.21%     
=================================================
  Files               146      146               
  Lines             14093    14021       -72     
=================================================
- Hits              10536     7790     -2746     
- Misses             3557     6231     +2674     
Impacted Files Coverage Δ
shared/src/sector/registered_proof.rs 0.82% <0.00%> (-5.77%) ⬇️

... and 58 files with indirect coverage changes

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the actual new proof enum types on the fil proofs library, but this fix looks correct given that we were returning the old values before.

@arajasek arajasek changed the base branch from release/v3.2 to release/v3.3 April 23, 2023 13:32
@arajasek arajasek merged commit c348967 into release/v3.3 Apr 23, 2023
11 checks passed
@arajasek arajasek deleted the asr/fix-type-conversion branch April 23, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants