This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Window based scheduling #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if scheduled { | ||
| heap.Remove(sh.schedQueue, i) | ||
| i-- | ||
| if len(acceptableWindows[sqi]) == 0 { |
There was a problem hiding this comment.
does this mean that the task will not get scheduled?
There was a problem hiding this comment.
Correct, because there's no window which can run it
It seems like the offset PC1's in your diagram here can never actually happen. All tasks in a window start when the window starts, and new tasks won't be added to the window while its running, correct? |
|
@magik6k it would be really great to have some tests of the scheduler that mock out time, so we can simulate different tasks taking different amounts of time and resources, and assert that things look like we expect them to. We can also use this to test the efficiency of the scheduler |
whyrusleeping
approved these changes
Jul 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix resource starvation issues caused by small tasks continuously using all resources, and making it impossible to run bigger tasks.
This is particularly visible if a worker was setup to run both precommit1+2: Assuming that there's a constant stream of both task types, and the worker can either run 2 PC1 tasks, or 1 PC2 task - when we were running 2 PC1 tasks, and one finished, we'd immediately schedule another PC1, even if we have 100 PC2 tasks waiting
Visually this would something like this
With this PR, we are scheduling tasks in batches / windows, where (currently, this can be made configurable later) one window is defined by what a worker can run in parallel
With this PR this should something like this
This already passes tests in lotus, now testing on my miner