Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

skip calculating hash if not check, or remove param #1364

Closed
austinabell opened this issue Jan 23, 2021 · 0 comments · Fixed by #1365
Closed

skip calculating hash if not check, or remove param #1364

austinabell opened this issue Jan 23, 2021 · 0 comments · Fixed by #1365
Assignees
@Stebalien
Projects
Lotus+Actors Board
Milestone
Network v14

Comments

@austinabell
Copy link
Contributor

in getting a msig transaction, if the checkHash is not set, the hash is calculated and gas charged even if the proposal hash is nil. Every use of this function sets checkHash to true, so this issue could be to remove that parameter to reduce confusion if not being planned to be used.

specs-actors/actors/builtin/multisig/multisig_actor.go

Line 513 in c7ea991

if checkHash {

Stebalien added a commit that referenced this issue Jan 24, 2021
@Stebalien
compute the hash of the proposal iff the proposal hash is present
0167588 
Previously, we'd always compute the hash but only _compare_ it if it
was specified. This simply increased the cost of messages that didn't
specify the hash for no good reason.

fixes #1364
@Stebalien Stebalien mentioned this issue Jan 24, 2021
Merged
@ZenGround0 ZenGround0 mentioned this issue Apr 8, 2021
Closed
28 tasks
@ZenGround0 ZenGround0 added this to the QoL Improvements milestone Aug 12, 2021
ZenGround0 pushed a commit that referenced this issue Aug 31, 2021
@Stebalien @ZenGround0
compute the hash of the proposal iff the proposal hash is present
b0bf345 
Previously, we'd always compute the hash but only _compare_ it if it
was specified. This simply increased the cost of messages that didn't
specify the hash for no good reason.

fixes #1364
ZenGround0 pushed a commit that referenced this issue Sep 3, 2021
@Stebalien @ZenGround0
compute the hash of the proposal iff the proposal hash is present
0a1a1b8 
Previously, we'd always compute the hash but only _compare_ it if it
was specified. This simply increased the cost of messages that didn't
specify the hash for no good reason.

fixes #1364
@jennijuju jennijuju added this to Backlog in Lotus+Actors Board Sep 3, 2021
ZenGround0 pushed a commit that referenced this issue Sep 7, 2021
@Stebalien @ZenGround0
compute the hash of the proposal iff the proposal hash is present
027ed02 
Previously, we'd always compute the hash but only _compare_ it if it
was specified. This simply increased the cost of messages that didn't
specify the hash for no good reason.

fixes #1364
Lotus+Actors Board automation moved this from Backlog to Closed Sep 8, 2021
ZenGround0 added a commit that referenced this issue Sep 8, 2021
@Stebalien @ZenGround0
compute the hash of the proposal iff the proposal hash is present (#1365
fd2767a 
)

* compute the hash of the proposal iff the proposal hash is present

Previously, we'd always compute the hash but only _compare_ it if it
was specified. This simply increased the cost of messages that didn't
specify the hash for no good reason.

fixes #1364

Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
Lotus+Actors Board
Closed
Milestone
Network v14
Development

Successfully merging a pull request may close this issue.

compute the hash of the proposal iff the proposal hash is present filecoin-project/specs-actors
3 participants
@Stebalien @ZenGround0 @austinabell