Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Miner control functions should abort for empty params #804

Closed
wadealexc opened this issue Jul 24, 2020 · 2 comments
Closed

Miner control functions should abort for empty params #804

wadealexc opened this issue Jul 24, 2020 · 2 comments

Comments

@wadealexc
Copy link

  • ChangePeerID should check that params.NewID is not empty

  • ChangeMultiaddrs should check that params.NewMultiaddrs is not empty

@anorth
Copy link
Member

anorth commented Jul 27, 2020

I'm not sure that the chain should be enforcing this. They're both opaque values as far as the rest of the chain state is concerned. If a miner doesn't want to advertise one of them for some reason, do we want to force them to put junk in there?

@whyrusleeping do you have an opinion here?

@anorth
Copy link
Member

anorth commented Aug 8, 2020

I'm going to close this in favour of #804. FYI @Stebalien please consider any minimum lengths we should also be enforcing.

@anorth anorth closed this as completed Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants