This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
FIP-0019: Minor fixes and test #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
commented
Nov 25, 2021
| } else if !exists { | ||
| return xc.ErrNotFound.Wrapf("sector %d not a member of partition %d, deadline %d", sector, pIdx, dlIdx) | ||
| return false, xc.ErrNotFound.Wrapf("sector %d not a member of partition %d, deadline %d", sector, pIdx, dlIdx) |
There was a problem hiding this comment.
treating a wrong location here as an error failure, agree?
Kubuxu
approved these changes
Nov 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #1534 +/- ##
========================================
- Coverage 69.3% 69.3% -0.1%
========================================
Files 72 72
Lines 8732 8737 +5
========================================
Hits 6060 6060
- Misses 1812 1817 +5
Partials 860 860 |
ZenGround0
reviewed
Dec 6, 2021
| // Returns an error if the target sector cannot be found, or some other bad state is reached. | ||
| // Returns false if the target sector is faulty, terminated, or unproven | ||
| // Returns true otherwise | ||
| func (st *State) CheckSectorHealthExcludeUnproven(store adt.Store, dlIdx, pIdx uint64, sector abi.SectorNumber) (bool, error) { |
There was a problem hiding this comment.
nit: a more succinct way to put this is CheckSectorActive
ZenGround0
reviewed
Dec 6, 2021
|
|
||
| // Prepare message. | ||
| params := miner.PreCommitSectorBatchParams{Sectors: make([]miner0.SectorPreCommitInfo, batchSize)} | ||
| if expiration == 0 { |
ZenGround0
reviewed
Dec 6, 2021
|
|
||
| info := vm.SectorInfo(t, v, minerAddrs.RobustAddress, sectorNumber) | ||
| require.Equal(t, 1, len(info.DealIDs)) | ||
| require.Equal(t, dealIDs[0], info.DealIDs[0]) |
There was a problem hiding this comment.
nit: check all other sector info fields, especially sector key and sealed sector id
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title.