This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
update go-ipld-format to remove globals, and use go-ipld-cbor explicitly #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
commented
Jun 5, 2023
| @@ -18,7 +18,7 @@ require ( | |||
| github.com/ipfs/go-block-format v0.0.3 | |||
| github.com/ipfs/go-cid v0.0.7 | |||
| github.com/ipfs/go-ipld-cbor v0.0.5 | |||
| github.com/ipfs/go-ipld-format v0.0.2 | |||
| github.com/ipfs/go-ipld-format v0.4.1-0.20230530195241-c3da01c74a06 | |||
| @@ -334,7 +335,7 @@ func (a *adtNodeGetter) Get(ctx context.Context, c cid.Cid) (format.Node, error) | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| return format.Decode(b) | |||
| return format.Decode(b, ipldcbor.DecodeBlock) | |||
There was a problem hiding this comment.
- It seems like you were only using dag-cbor here, is that true?
- Would you find it more helpful to either
a) just doipldcbor.DecodeBlock(b)instead of using the helper in go-ipld-format for checking if the Block is already a Node?
b) have a registry object you can create and use (either as a global in this file or passed into the constructor) so that you getmyRegistry.Decode(b)
|
Closing down because we are archiving |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming along the same set of changes as filecoin-project/lotus#10921.
The change to go-ipld-format hasn't been merged + released yet but should soon so please let me know if there's a problem