Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): filecoin VM interface update #1056

Merged
merged 4 commits into from Sep 4, 2020
Merged

Conversation

yiannisbot
Copy link
Collaborator

This PR is updating the content on the Filecoin VM Interface. It also adds some introductory content to the overall VM section, which might be updated with more content at a later stage.

@yiannisbot yiannisbot marked this pull request as ready for review August 13, 2020 17:21
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure what's expected here. Most of the prose is ok, but some of it and much of the code is details of one particular implementation that would not be relevant to others.

content/systems/filecoin_vm/_index.md Outdated Show resolved Hide resolved
content/systems/filecoin_vm/actor/_index.md Outdated Show resolved Hide resolved
content/systems/filecoin_vm/actor/_index.md Outdated Show resolved Hide resolved
@schomatis
Copy link
Contributor

Agree with @anorth regarding the code.

@yiannisbot
Copy link
Collaborator Author

@anorth @schomatis I've excluded the code blocks and left the narrative only. Let me know if we should expand to include some central concept that is missing in the current version.

anorth
anorth previously approved these changes Sep 1, 2020
content/systems/filecoin_vm/actor/_index.md Outdated Show resolved Hide resolved
@yiannisbot yiannisbot added the hint: ready to merge Hint: PR is ready to be merged label Sep 3, 2020
@hugomrdias hugomrdias changed the base branch from beta to master September 4, 2020 10:54
@hugomrdias hugomrdias dismissed anorth’s stale review September 4, 2020 10:54

The base branch was changed.

@hugomrdias hugomrdias changed the title Filecoin VM Interface Update fix(content): filecoin VM interface update Sep 4, 2020
@hugomrdias hugomrdias merged commit 0a4f6fb into master Sep 4, 2020
@hugomrdias hugomrdias deleted the fil-vm-interface branch September 4, 2020 10:55
hugomrdias added a commit that referenced this pull request Sep 7, 2020
* master: (27 commits)
  fix(content): filecoin VM interface update (#1056)
  fix(content): chainsync section update (#1123)
  fix(content): libraries section update (#1115)
  fix: show hugo errors on build
  docs: tidy up the readme, add toc. (#1141)
  fix: reword stacked drg missing link text"
  fix: fix broken refs and change warns to errors (#1139)
  fix: import meter css (#1140)
  feat: build toc and dashboard in hugo (#1122)
  feat: show wip and reliable in progress bar (#1137)
  content: fix typo plus remove definition of weight (#1138)
  fix: css for label style and dashboard link (#1136)
  feat: add symbol embeds and listing (#1126)
  v1.0.1
  feat(tooling): release scripts
  v1.0.0
  chore: update readme and package.json
  fix: update dns link
  fix: fix broken links
  fix(content): FIL VM System Actors Update (#1061)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint: ready to merge Hint: PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants