Remove duplication of the storage market actor interface in storage-market.md #324
Conversation
actors.md
Outdated
| @@ -186,16 +189,16 @@ Parameters: | |||
| Return: Address | |||
|
|
|||
| ```go | |||
| func CreateStorageMiner(worker Address, sectorSize BytesAmount, pid PeerID) Address { | |||
There was a problem hiding this comment.
this change is incorrect. please keep it as an address.
There was a problem hiding this comment.
Roger that. I inferred pubkey from its use at 198, and storage-market.md. Address is consistent with the constructor.
actors.md
Outdated
| miner.SelfDestruct() | ||
| } | ||
| ``` | ||
|
|
||
| ### SlashStorageFault | ||
|
|
||
| > SlashStorageFault penalizes a storage miner for not submitting a PoSt within the required [time window](#TODO-link-to-faulty-submission). This may be called by anyone who detects the faulty behavior. The slashed miner loses all of their staked collateral and all of their power, and as a result, is no longer a candidate leader for extending the chain. See [faults](faults.md). |
There was a problem hiding this comment.
its worth linking directly to the unreported storage fault slashing section that this is for.
Also, what is 'TODO-link-to-faulty-submission' supposed to link to?
There was a problem hiding this comment.
- Linkified.
- I don't know, I copied this from
storage-market.md. I'll remove the TODO if you don't know what it's standing for.
actors.md
Outdated
|
|
||
| ```go | ||
| func SlashStorageFault(miner Address) { | ||
| // TODO |
There was a problem hiding this comment.
+1, will file an issue, thanks
There was a problem hiding this comment.
ah, right. I thought I had written this already, its a method on the miner itself.
There was a problem hiding this comment.
It was initially on the storage market, but all it did was call through to a method on the miner, and didnt actually do anything on the storage market, so it was moved to the miner.
It definitely feels weird to have the consensus slashing here, and the storage slashing there though, so I could be convinced that it should be moved back. But we would then be adding network overhead for a small UX improvement.
There was a problem hiding this comment.
Ah, of course, thanks for spotting. I'll remove this.
anorth
force-pushed
the
anorth/actors
branch
2 times, most recently
from
c6caf91
to
56a8d3a
Compare
|
|
||
| TODO: rephrase the above to make it clear that power is updated only on PoSt submission and when slashed. | ||
| Each individual miner reports its power through its on-chain actor. A miner's power (and hence the total power) is updated only upon PoSt submission (when the set of sectors being proved may change) or when a miner is slashed. |
There was a problem hiding this comment.
Might be good to note that this submission is dependent on the individual miner, rather than a global operation
There was a problem hiding this comment.
Actually this is already clear, as this is talking about a specific miner, nvm
|
@whyrusleeping ready for merge. |
|
It looks like this has rotted and will need re-doing against the changed actors spec. |
sorry about that, please ping me when you have rebased onto |
|
@anorth Could you please rebase onto |
|
It's a bunch of mechanical work - I don't expect to get to it soon. Feel
free also to close and have someone else do it if this PR is in the way.
…On Wed, 28 Aug 2019 at 02:46, Pooja ***@***.***> wrote:
@anorth <https://github.com/anorth> Could you please rebase onto master?
We can merge it in afterwards!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#324?email_source=notifications&email_token=AADMW6SB4YH7D3H27CYC64DQGVK5VA5CNFSM4HSEB3R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IMHIQ#issuecomment-525386658>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADMW6VKIJTP7GXPFRCW5JTQGVK5VANCNFSM4HSEB3RQ>
.
|
This exposes thatSlashStorageFaultis currently missing pseudocode.Re: #92, #292