Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs.next | beta.specs.filecoin.io #969

Closed
wants to merge 43 commits into from
Closed

Conversation

hugomrdias
Copy link
Contributor

next/content/math-mode.md Outdated Show resolved Hide resolved
next/.site/layouts/partials/docs/inject/body.html Outdated Show resolved Hide resolved
next/.site/layouts/partials/docs/inject/body.html Outdated Show resolved Hide resolved
hugomrdias and others added 6 commits July 14, 2020 17:24
These are the original documents, which won't work directly with Hugo.

The purpose of this commit is to have a copy of the original documents
and also a way to confirm easily that the ones modified to work with
Hugo didn't introduce any mistakes.
This commit doesn't change the SDR specification itself, but only makes
it render properly. This commit should be reviewed to make sure that
not accidental errors were introduced.
…to feat/new-setup

* 'feat/new-setup' of github.com:filecoin-project/specs:
  docs: make SDR spec render correctly
  docs: add original SDR specification
@olizilla
Copy link
Collaborator

@jbenet work on the specs upgrade is going on in this PR. Latest rendered preview is here https://deploy-preview-969--fil-spec-staging.netlify.app/ (the deploy/netlify status check details will always have the most recent rendered preview)

…to feat/new-setup

* 'feat/new-setup' of github.com:filecoin-project/specs:
  feat: simplified workflow to add next to ipfs (#981)
@daviddias daviddias changed the title feat: new hugo setup specs.next | beta.specs.filecoin.io Jul 17, 2020
@daviddias
Copy link
Contributor

Some nits on usability:

image

image

image

image

@daviddias
Copy link
Contributor

image

@olizilla
Copy link
Collaborator

olizilla commented Jul 17, 2020

can you make these always be expanded

@daviddias can you state the problem you are feeling? Can you frame your feedback in terms of what you need to be productive? Is it that you can't find sections without seeing an over view of all the headings on the left?

can we haz algolia search

YES

spinner madness!

I feel the same. It gives me an sense that something is failing to load. I think this will change as the dashboard settles.

replace this section with a link to the grid

We will iterate on how to show the spec status in each section, and include a link to the dashboard

@daviddias
Copy link
Contributor

@daviddias can you state the problem you are feeling? Can you frame your feedback in terms of what you need to be productive? Is it that you can't find sections without seeing an over view of all the headings on the left?

That's correct. And given that now each section is a separate page, I have to wait for the whole HTTP RTT to get the next page, which makes skimming and understanding where things are and how they are organized much harder.

The previous page solved this with a slider

image

@yiannisbot
Copy link
Collaborator

replace this section with a link to the grid

We will iterate on how to show the spec status in each section, and include a link to the dashboard

We will certainly include a link to the grid/dashboard. However, I think it would be useful to have a summarising, e.g., per section, overview here. I'm not clear whether the summarising one should be in the form it is now, or as a table/grid, but let's iterate on this to get feedback.

@davidad
Copy link
Member

davidad commented Jul 17, 2020

My feedback:

  1. Using an animated icon as a symbolic glyph goes against UX guidelines, which point out that animation draws the user's attention, so it should be unobtrusive and brief (source), or in response to user actions or state transitions (source).
  2. It would be nice to be able to expand multiple parts of the sidebar at once; I'd also like an "expand all" button.
  3. The search function doesn't show me where on the matching page the match was found, neither by highlighting or scrolling. I can do a Cmd-F, but now I have to search for the same thing twice.
  4. There's no "show as a single page" to enable Cmd-F alone to search the whole spec.

I see that all these points have basically already been covered by @daviddias but hope it's helpful to hear it from another user.

@dignifiedquire
Copy link
Contributor

Screenshot 2020-07-17 at 11 49 02

This tiny embedded frame of a PDF is not really useful, either this should be converted into spec content, or just an external link

@dignifiedquire
Copy link
Contributor

It would be great to have a light mode, I know there are a lot of fans of dark mode, but I feel it is quite hard to read for longer forms of text.

@nicola
Copy link
Contributor

nicola commented Jul 17, 2020

Same here, light mode please, it is dark and the text is too gray for me :(

@olizilla olizilla added this to In progress in beta.spec.filecoin.io Jul 17, 2020
This was referenced Jul 17, 2020
@hugomrdias
Copy link
Contributor Author

Thank for all the feedback keep it coming !! We will improve based on it, you can already see here https://github.com/filecoin-project/specs/projects/8 our planing.

…to feat/new-setup

* 'feat/new-setup' of github.com:filecoin-project/specs:
  feat: update dnslink to deploy (#982)
@hugomrdias
Copy link
Contributor Author

This PR will be closed in favor of the beta branch which will be the default branch from now on. The previous setup still lives in the master branch until we finish the beta.

For more feedback please use this issue #992
Thank you.

@hugomrdias hugomrdias closed this Jul 20, 2020
beta.spec.filecoin.io automation moved this from In progress to Done Jul 20, 2020
@hugomrdias hugomrdias deleted the feat/new-setup branch July 20, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants