Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Market attribute-related api add miner para #5464

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Nov 10, 2022

关联的Issues (Related Issues)

#5410

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen self-assigned this Nov 10, 2022
@diwufeiwen diwufeiwen marked this pull request as draft November 10, 2022 08:55
@diwufeiwen diwufeiwen marked this pull request as ready for review November 11, 2022 09:28
@diwufeiwen diwufeiwen force-pushed the feat/lt/market_prop_api_add_miner branch from 1bafd56 to c5468c0 Compare November 16, 2022 06:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #5464 (e4269a8) into release/v1.9.0-pre-rc (b80c8fc) will decrease coverage by 0%.
The diff coverage is 0%.

❗ Current head e4269a8 differs from pull request most recent head 922177a. Consider uploading reports for the commit 922177a to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/v1.9.0-pre-rc   #5464    +/-   ##
======================================================
- Coverage                     24%     24%    -1%     
======================================================
  Files                        608     608            
  Lines                      68089   68236   +147     
======================================================
  Hits                       16896   16896            
- Misses                     49010   49156   +146     
- Partials                    2183    2184     +1     

@diwufeiwen diwufeiwen force-pushed the feat/lt/market_prop_api_add_miner branch 2 times, most recently from 7038f50 to aab91a4 Compare November 16, 2022 06:49
LinZexiao
LinZexiao previously approved these changes Nov 16, 2022
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen force-pushed the feat/lt/market_prop_api_add_miner branch 2 times, most recently from 7375e22 to e4269a8 Compare November 18, 2022 01:18
@diwufeiwen diwufeiwen force-pushed the feat/lt/market_prop_api_add_miner branch from e4269a8 to e9ae28a Compare November 23, 2022 08:25
@diwufeiwen diwufeiwen force-pushed the feat/lt/market_prop_api_add_miner branch from e9ae28a to 922177a Compare November 23, 2022 08:40
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit 7ccaf07 into release/v1.9.0-pre-rc Nov 24, 2022
@simlecode simlecode deleted the feat/lt/market_prop_api_add_miner branch November 24, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants