Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:修复启动时重复注册topic的问题 / use sync once to provent join topic repeatly #5608

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

hunjixin
Copy link
Contributor

关联的Issues (Related Issues)

close #5575

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@hunjixin hunjixin self-assigned this Dec 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #5608 (cd6b8c7) into master (792b31b) will increase coverage by 0%.
The diff coverage is 20%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5608   +/-   ##
======================================
  Coverage      26%     26%           
======================================
  Files         613     613           
  Lines       69430   69434    +4     
======================================
+ Hits        18067   18083   +16     
+ Misses      48981   48973    -8     
+ Partials     2382    2378    -4     

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit 0182082 into master Dec 22, 2022
@simlecode simlecode deleted the fix/topic_repeat_join branch December 22, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus] venus panic for topice exist / venus崩溃, topic exit
3 participants