Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 重命名replacedmsg为nonceconflict, rename replacedmsg to nonceconfict #5637

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jan 9, 2023

关联的Issues (Related Issues)

close #5612

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #5637 (4c28ee5) into master (dc12405) will increase coverage by 0%.
The diff coverage is 0%.

❗ Current head 4c28ee5 differs from pull request most recent head 238fcc7. Consider uploading reports for the commit 238fcc7 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5637   +/-   ##
======================================
  Coverage      26%     26%           
======================================
  Files         613     613           
  Lines       69467   69467           
======================================
+ Hits        18078   18084    +6     
+ Misses      49006   48999    -7     
- Partials     2383    2384    +1     

@hunjixin hunjixin force-pushed the feat/rename_replacedmsg_state branch from 4c28ee5 to 238fcc7 Compare January 9, 2023 09:09
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit 364762c into master Jan 9, 2023
@simlecode simlecode deleted the feat/rename_replacedmsg_state branch January 9, 2023 09:44
@hunjixin hunjixin changed the title feat: rename replacedmsg to nonceconfict feat: 重命名replacedmsg为nonceconflict, rename replacedmsg to nonceconfict Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-messager] clarify messager state(replace) / 换一个更贴切的Replace状态名称,避免歧义。
3 participants