Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade market-event api #5703

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Feb 8, 2023

关联的Issues (Related Issues)

ref #5484

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #5703 (61e06b8) into master (6776ccf) will increase coverage by 1%.
The diff coverage is 0%.

❗ Current head 61e06b8 differs from pull request most recent head c105ca7. Consider uploading reports for the commit c105ca7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #5703     +/-   ##
========================================
+ Coverage      24%     26%     +1%     
========================================
  Files         643     612     -31     
  Lines       77794   69453   -8341     
========================================
- Hits        19392   18081   -1311     
+ Misses      55811   48987   -6824     
+ Partials     2591    2385    -206     

@diwufeiwen diwufeiwen force-pushed the feat/lt/upgrade_market_event_api branch from fb64fb6 to 50acd4b Compare February 9, 2023 02:08
@diwufeiwen diwufeiwen self-assigned this Feb 9, 2023
@diwufeiwen diwufeiwen force-pushed the feat/lt/upgrade_market_event_api branch from 50acd4b to 61e06b8 Compare February 9, 2023 06:44
@diwufeiwen diwufeiwen force-pushed the feat/lt/upgrade_market_event_api branch from 61e06b8 to c105ca7 Compare March 20, 2023 06:18
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hunjixin hunjixin merged commit a928287 into master Mar 21, 2023
@hunjixin hunjixin deleted the feat/lt/upgrade_market_event_api branch March 21, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants