Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new vm exec tracer / 使用新的 vm 执行追踪模块 #5901

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Apr 12, 2023

关联的Issues (Related Issues)

#5818
dep : #5900
ref: filecoin-project/lotus#10625

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #5901 (39bf7e9) into feat/nv19 (6b499d9) will decrease coverage by 1%.
The diff coverage is 4%.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat/nv19   #5901    +/-   ##
==========================================
- Coverage         24%     24%    -1%     
==========================================
  Files            657     656     -1     
  Lines          79436   79565   +129     
==========================================
- Hits           19528   19526     -2     
- Misses         57322   57449   +127     
- Partials        2586    2590     +4     

@LinZexiao LinZexiao force-pushed the feat/new-vm-exec-tracer branch 2 times, most recently from 78fcd9e to 9a3a5ee Compare April 12, 2023 11:24
@LinZexiao LinZexiao marked this pull request as draft April 13, 2023 01:14
pkg/vm/vmcontext/vmcontext.go Show resolved Hide resolved
pkg/vm/vmcontext/vmcontext.go Show resolved Hide resolved
pkg/vm/vmcontext/vmcontext.go Show resolved Hide resolved
pkg/vm/vmcontext/vmcontext.go Show resolved Hide resolved
@LinZexiao LinZexiao marked this pull request as ready for review April 13, 2023 05:04
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LinZexiao LinZexiao merged commit 3ef790f into feat/nv19 Apr 13, 2023
2 checks passed
@LinZexiao LinZexiao deleted the feat/new-vm-exec-tracer branch April 13, 2023 06:24
LinZexiao added a commit that referenced this pull request Apr 20, 2023
…ec-tracer"

This reverts commit 3ef790f, reversing
changes made to 0c460e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants