Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not save data to event table #6184

Merged
merged 2 commits into from Oct 13, 2023
Merged

fix: not save data to event table #6184

merged 2 commits into from Oct 13, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

  1. 调整配置文件字段的命名
  2. 修复 event index 迁移较慢问题
  3. 修复没有把 event 信息写到 sqlite

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #6184 (6c1c56e) into master (c45232a) will increase coverage by 0%.
Report is 1 commits behind head on master.
The diff coverage is 15%.

❗ Current head 6c1c56e differs from pull request most recent head 598fb41. Consider uploading reports for the commit 598fb41 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6184   +/-   ##
======================================
  Coverage      24%     24%           
======================================
  Files         679     679           
  Lines       84003   84003           
======================================
+ Hits        20176   20200   +24     
+ Misses      61158   61132   -26     
- Partials     2669    2671    +2     

Copy link
Collaborator

@0x5459 0x5459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0x5459

This comment was marked as duplicate.

@0x5459 0x5459 merged commit 42ca9c9 into master Oct 13, 2023
3 checks passed
@0x5459 0x5459 deleted the fix/eth-event branch October 13, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants