Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Support Apple Silicon M1/M2 (darwin arm64) #35

Closed
1 of 2 tasks
bajtos opened this issue Jul 13, 2022 · 5 comments
Closed
1 of 2 tasks

Support Apple Silicon M1/M2 (darwin arm64) #35

bajtos opened this issue Jul 13, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@bajtos
Copy link
Contributor

bajtos commented Jul 13, 2022

We are already building darwin-arm64 version of saturn-l2. Early versions up to v0.0.3 worked well. Starting from the version v0.0.4, the darwin-arm64 version crashes at startup:

./saturn-l2
[1]    16654 killed     ./saturn-l2

This is probably required to enable Apple Silicon support for Filecoin Station, see filecoin-station/desktop#35

Possibly related threads:

TODO

@bajtos
Copy link
Contributor Author

bajtos commented Jul 19, 2022

@lidel I'd like to setup Windows & Apple signing for the binaries published by this project. Could you please configure the necessary GitHub Secrets so that I can pass them to GoReleaser?

Here are the secrets used by Filecoin-station:
https://github.com/filecoin-project/filecoin-station/blob/dd515d0a040585713bdaae2e945232e69d5ea4a7/.github/workflows/ci.yml#L114-L124

GoReleaser docs: https://goreleaser.com/customization/sign/#with-gon

I am not sure if GoReleaser can sign Windows executable too. My goal is to run Arm64 version of macOS binaries, so Apple signing is enough for now.

@lidel
Copy link

lidel commented Jul 19, 2022

@bajtos you'd have to make me Maintainer or Admin of this repo: I don't see the Settings tab atm.

While I am happy to help you with this, perhaps it is better if you do it yourself: this is a good opportunity to remove a single point of failure from your release pipeline (my availability).

thoughts? iiuc if anything happens to me and apple signing stops working, you will be in firefighting mode to figure things out. I believe Saturn team should have Apple Developer accounts and access to signing-related secrets in the vault, so your team is not blocked on me.

@bajtos bajtos assigned bajtos and unassigned bajtos Jul 20, 2022
@bajtos
Copy link
Contributor Author

bajtos commented Jul 20, 2022

While I am happy to help you with this, perhaps it is better if you do it yourself: this is a good opportunity to remove a single point of failure from your release pipeline (my availability).

That's a great idea!

@juliangruber will work on this.

@juliangruber juliangruber self-assigned this Jul 20, 2022
juliangruber added a commit that referenced this issue Sep 27, 2022
* sign and notarize (wip)

* always run for now

* add install gon

* try fixing the rate limiting issue

* just always run on macos

* change gon invocation

* try again after updating env

* try again after updating env

* try again after updating env

* try again after updating env

* pass secrets to env

* import cert into keychain

* just pass the cert name (no secret)

* fix build id

* fix build id

* build on all darwin architectures

* add sign arm64

* fix hcl syntax

* undo debug changes

* clean up

* attach artifacts to workflow run

* run on push again

* clean up

* update bundle id

* use hooks instead of signs

* turn gon config into dotfile

* add zip output

* try "signs" again

* try mirroring mitchellh/gon setup

* update paths

* 🤔

* looks like username needs to be hardcoded

* clean up

* attach everything from `./dist`

* remove unnecessary dmg artifact

* undo some changes

* only archive macos

* undo some changes

* undo some changes

* undo some changes

* zip -> tar.gz

* add arch to macos artifact

* remove version from other builds too

* skip folder artifact upload

* Revert "zip -> tar.gz"

This reverts commit c49d051.

* docs

* keep previous artifact naming

* fix artifact name

* build all darwin archs

* sign macos archs independently

* refactor, fix redundant signs ids

* consistent naming

* fix signing source paths

* fix source path again

* arm signing issues

* clean up

* always run

* try manual arm script

* fix path

* fix paths

* wait, why is x86_64 failing now

* fix sign command

* switch back to gon, remove arm signing attempts again

* Update bundle_id

Co-authored-by: Miroslav Bajtoš <saturn@bajtos.net>

Co-authored-by: Miroslav Bajtoš <saturn@bajtos.net>
@bajtos
Copy link
Contributor Author

bajtos commented Jan 8, 2024

IIRC, we have already implemented the necessary changes and this GH issue can be closed as done.

@juliangruber feel free to open follow-up issue(s) for any improvements or bugs you are aware of.

@bajtos bajtos closed this as completed Jan 8, 2024
@bajtos bajtos reopened this Jan 8, 2024
@bajtos
Copy link
Contributor Author

bajtos commented Jan 8, 2024

Ah, I was in a wrong repo 🙈

I don't think anybody needs Saturn L2 on Apple Silicon, so let's close this as not planned.

@bajtos bajtos closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants