This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Improve retry logic #151
Merged
Improve retry logic #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
commented
Aug 24, 2023
caboose.go
Outdated
| @@ -85,11 +85,12 @@ const DefaultLoggingInterval = 5 * time.Second | |||
| const DefaultSaturnOrchestratorRequestTimeout = 30 * time.Second | |||
|
|
|||
| const DefaultSaturnBlockRequestTimeout = 19 * time.Second | |||
| const DefaultSaturnCarRequestTimeout = 30 * time.Minute | |||
|
|
|||
| const DefaultSaturnCarRequestTimeout = 1 * time.Minute | |||
There was a problem hiding this comment.
Max P95 for a successful CAR fetch over the last 24 hours in prod is 30 seconds:
There was a problem hiding this comment.
does this mean that a large movie won't work anymore?
I don't think this is an acceptable limit.
There was a problem hiding this comment.
Hmmm, I see what you mean.
There was a problem hiding this comment.
@willscott Reverted this change.
aarshkshah1992
commented
Aug 24, 2023
| const DefaultSaturnMirrorRequestTimeout = 30 * time.Second | ||
|
|
||
| // default retries before failure unless overridden by MaxRetrievalAttempts | ||
| const defaultMaxRetries = 3 | ||
| const defaultMaxRetries = 2 |
There was a problem hiding this comment.
~99% of ALL requests that succeed do so in the first two retries:
aarshkshah1992
commented
Aug 24, 2023
| @@ -236,9 +236,9 @@ func (p *pool) fetchResource(ctx context.Context, from string, resource string, | |||
| // which is the amount of time without any NEW data from the server, but | |||
| // that can be added later. We need both because a slow trickle of data | |||
| // could take a large amount of time. | |||
| requestTimeout := DefaultSaturnCarRequestTimeout | |||
| requestTimeout := time.Duration(DefaultSaturnCarRequestTimeout.Milliseconds()/int64(attempt+1)) * time.Millisecond | |||
There was a problem hiding this comment.
Reduces timeout duration with each retry.
willscott
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve retry logic