This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Revamp caboose metrics #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feat/downvote-based-return-codes
to
lock-cleanup
February 22, 2023 17:44
lidel
suggested changes
Feb 22, 2023
aarshkshah1992
force-pushed
the
feat/metrics-collection-work
branch
from
ccc7141
to
3565ec6
Compare
This will make things easier when we have to add cars.
This gives us more useful buckets (same width)
It is a good practice to avoid defining buckets with values that may change. By hardcoding bucket definitions this way, we avoid breaking grafana boards when someone decides to adjust a timeout. If we ever need to change buckets, or add new one with bigger max, but keep old ones intact, we can define them by hand.
lidel
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Thank you @aarshkshah1992!
I've pushed cosmetic changes:
- small renames to make it clear which metrics are about blocks. this is in preparation for future CAR/graph fetches (Support non-block requests #45) that will be done in addition to block ones
- linear buckets for size (we will most likely see majority being ~256 KiB and ~1 MiB blocks on heatmap)
- some precautions to not break grafana boards using histograms (see ℹ️ below)
Comment on lines
+8
to
+9
| // Size buckets from 256 KiB (default chunk in Kubo) to 4MiB (maxBlockSize), 256 KiB wide each | ||
| blockSizeHistogram = prometheus.LinearBuckets(262144, 262144, 16) |
There was a problem hiding this comment.
ℹ️ This gives us more useful buckets (same width), and we can plot them in Grafana using heatmap widget
Comment on lines
+11
to
+17
| // TODO: Speed max bucket could use some further refinement, | ||
| // for now we don't expect speed being bigger than transfering 4MiB (max block) in 500ms | ||
| speedHistogram = prometheus.ExponentialBucketsRange(1, 4194304/500, 20) | ||
|
|
||
| // Duration max bucket is informed by the timeouts per block and per peer request/retry | ||
| durationPerBlockHistogram = prometheus.ExponentialBucketsRange(1, 60000, 10) | ||
| durationPerBlockPerPeerHistogram = prometheus.ExponentialBucketsRange(1, 20000, 10) |
There was a problem hiding this comment.
ℹ️ I've just remembered that it is a good practice to avoid defining buckets with values that may
change. By hardcoding bucket definitions this way, we avoid breaking grafana boards when someone decides to adjust a timeout.
If we ever need to change buckets, or add new one with bigger max, but keep old ones intact, we can define them as explicit list of values (like we did with legacy ones in kubo a while ago):
[]float64{0.05, 0.1, 0.25, 0.5, 1, 2, 5, 10, 30, 60}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34