This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
feat: open telemetry tracing #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
suggested changes
Apr 24, 2023
|
I just removed the prefix |
lidel
approved these changes
Apr 25, 2023
lidel
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
lgtm, should be good enough for now
@willscott / @aarshkshah1992 ok to merge? we can add more spans in the future, if needed
willscott
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Open Telemetry tracing spans. Context: ipfs/bifrost-gateway#68 (comment).
This is not necessarily required. On the screenshot below you see the tracing result from the Bifrost Gateway up until the HTTP request Caboose makes to the Saturn node. What this PR adds is the
Caboose.*trace spans. The HTTP GET already worked.@lidel @willscott not sure where is the most value to put the spans here, but this seems like a good start. Feel free to add/remove some.