Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Voyager crashes into info #401

Merged
merged 2 commits into from
Apr 11, 2024
Merged

change Voyager crashes into info #401

merged 2 commits into from
Apr 11, 2024

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Apr 9, 2024 •
edited
Loading

Screenshot 2024-04-09 at 16 27 57

There's nothing that operators can do about these crashes. This PR changes the activity type into "Info"

@juliangruber juliangruber requested a review from bajtos April 9, 2024 14:28
juliangruber
juliangruber commented Apr 10, 2024
View reviewed changes
lib/zinnia.js Outdated Show resolved Hide resolved
bajtos
bajtos approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, this feels very hacky to me. I prefer to handle these crashes in such a way that no activity logs are created. However, that requires quite a bit of work, starting in Zinnia. In this light, it's best to land this fix as a quick stop-gap solution.

lib/zinnia.js Outdated Show resolved Hide resolved
@bajtos bajtos mentioned this pull request Apr 11, 2024
Open
@bajtos
Copy link
Member

bajtos commented Apr 11, 2024

Created a Zinnia feature request here:

@juliangruber
Copy link
Member Author

I very much agree!

@juliangruber juliangruber enabled auto-merge (squash) April 11, 2024 08:30
@juliangruber juliangruber merged commit ad71623 into main Apr 11, 2024
18 checks passed
@juliangruber juliangruber deleted the fix/voyager-error-display branch April 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliangruber @bajtos