fix: always build for x64 on macOS #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, when running `npm run package` on an Apple M1/M2 computer, electron builder was creating a package for `arm64`. Since we are not downloading Saturn L2 node for `arm64`, we ended up with a broken Station app. In this commit, I am changing electron-builder config to always build for `x64` when running on macOS. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
|
Extracted from #294 |
juliangruber
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when running
npm run packageon an Apple M1/M2 computer, electron builder was creating a package forarm64. Since we are not downloading Saturn L2 node forarm64, we ended up with a broken Station app.In this commit, I am changing electron-builder config to always build for
x64when running on macOS.