feat: tray & app menu item "Check for Updates..." #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
commented
Jul 27, 2022
bajtos
commented
Jul 27, 2022
Comment on lines
+59
to
+62
| // TODO: replace this with autoUpdater.checkForUpdatesAndNotify() | ||
| autoUpdater.checkForUpdates() |
There was a problem hiding this comment.
This todo comment is coming from the original source code. I am not sure if it's still relevant. Do you remember @lidel why you would like to switch from autoUpdater.checkForUpdates() to autoUpdater.checkForUpdatesAndNotify()?
There was a problem hiding this comment.
I vaguely remember that the rationale was that it is less code to maintain, and that meant smaller surface for breaking autoupdates when upstream APIs change in subtle ways (happened in the past)
bajtos
force-pushed
the
feat-better-updater-ux
branch
from
9f35655
to
289ca2e
Compare
juliangruber
requested changes
Jul 28, 2022
This was referenced Jul 28, 2022
|
@juliangruber I addressed your feedback in 172bf3b.
LGTY now? |
juliangruber
reviewed
Aug 1, 2022
juliangruber
approved these changes
Aug 1, 2022
When the check is running, replace "Check for Updates" with a disabled item "Checking for Updates". Signed-off-by: Miroslav Bajtoš <saturn@bajtos.net>
bajtos
force-pushed
the
feat-better-updater-ux
branch
from
af82612
to
97373e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Check for Updates..." to the Tray menu. On macOS, add this item to the Application menu too. While the check is running, replace "Check for Updates" with a disabled item "Checking for Updates".
See #53
The implementation is heavily inspired by IPFS Desktop:
Out of scope
Screenshots
A new macOS application menu item:
While checking for updates:
A new Tray menu item:
While checking for updates:
Various dialogs shown by the app:
The annoying notification we should remove later: