Fix more Core crashes #692

juliangruber · 2023-05-11T11:14:59Z

No description provided.

bajtos

I like that you removed the execa dependency 👍🏻

I don't fully understand the fix, though; see my comments below.

main/tray.js

main/core.js

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>

bajtos

LGTM after I removed extraResources config that seems to be not needed.

If you find that it's needed, then the previous version with extraResources is fine with me too.

Please consider adding a code comment as I suggested in my comment below.

main/core.js

electron-builder.yml

main/core.js

juliangruber · 2023-05-12T06:26:35Z

juliangruber added 4 commits May 11, 2023 13:13

replace execa with child_process.fork

da99390

unpack asar

bfdc2e3

zinnia needs $HOME and possibly more from the env

f2863ee

fix tray updates from before watching for events

1b22894

bajtos reviewed May 11, 2023

View reviewed changes

main/tray.js Outdated Show resolved Hide resolved

main/core.js Show resolved Hide resolved

clean up

d936b4a

juliangruber requested a review from bajtos May 11, 2023 11:27

remove unecessary extraResources build config

1377183

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>

bajtos approved these changes May 11, 2023

View reviewed changes

main/core.js Show resolved Hide resolved

electron-builder.yml Outdated Show resolved Hide resolved

main/core.js Show resolved Hide resolved

docs

1ccbc52

juliangruber merged commit eddd4de into main May 12, 2023
4 checks passed

juliangruber deleted the fix/core-crash branch May 12, 2023 06:04

Provide feedback