feat: Add station_id field to measurements storage and publishing #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickNercessian
changed the title
bajtos
approved these changes
Apr 17, 2024
bajtos
changed the title
|
@PatrickNercessian What's the status of this pull request? Is there anything left to improve or is it good to be landed? |
|
You will also need to update the branch to bring the commits that landed on the |
|
@bajtos I was going to do new PR for stationId constraints as you mentioned, but noticed there were some other code churn updates that could be reduced as we did in other PRs, so I thought I'd combine both. Let me know your thoughts. |
bajtos
reviewed
Apr 18, 2024
bajtos
approved these changes
Apr 18, 2024
juliangruber
approved these changes
Apr 18, 2024
|
The required CI checks will run after we land #254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT, DO NOT MERGE
Links:
filecoin-station/roadmap#96