Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add an example module - ping-probe #96

Merged
merged 5 commits into from Mar 7, 2023
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Mar 7, 2023

Related:

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

examples/ping-probe/README.md Outdated Show resolved Hide resolved
const INFLUXDB_API_KEY = "FILL ME IN!";
const INFLUXDB_ORG_ID = "FILL ME IN!";
const INFLUXDB_BUCKET = "FILL ME IN!";
const INFLUXDB_ENDPOINT = "https://eu-central-1-1.aws.cloud2.influxdata.com/";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be the same for all users, or should we parameterise it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, it will change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will change. I am keeping this value to show what the correct value looks like - it's the "base path" without any specific endpoint path.

bajtos and others added 3 commits March 7, 2023 13:47
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos enabled auto-merge (squash) March 7, 2023 12:53
@bajtos bajtos mentioned this pull request Mar 7, 2023
4 tasks
@bajtos bajtos merged commit 05fb774 into main Mar 7, 2023
11 checks passed
@bajtos bajtos deleted the example-ping-probe branch March 7, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants