Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test rpc methods #294

Merged
merged 7 commits into from
Sep 5, 2023
Merged

test rpc methods #294

merged 7 commits into from
Sep 5, 2023

Conversation

koschos
Copy link
Contributor

@koschos koschos commented Aug 25, 2023 •
edited
Loading

Description

This PR covers part of the tech debt issue 137

Notes

  • minor refactoring in block/verifiers.go to remove duplicates and simplify getting a peer ID from a verifier
  • added test helpers and matches in the test folder
  • added tests for rpc/storage.go - test coverage now is 75%

@koschos koschos marked this pull request as ready for review September 2, 2023 21:45
filefilegoadmin
filefilegoadmin approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@filefilegoadmin filefilegoadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thank you for this PR

@filefilegoadmin filefilegoadmin merged commit 4a7fd1e into filefilego:master Sep 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filefilegoadmin filefilegoadmin filefilegoadmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koschos @filefilegoadmin