# 4.2.5 2022-03-22

* [bug] repair the problem about when all the connections from agents are disconnected, the method effect may still work, and change state, if it is a asynchronous method.

docs/changes.md

@@ -171,4 +171,8 @@ in this version, `runtime.cache` used in MiddleWare is independent.
 
 # 4.2.4 2022-03-21
 
-* [optimize] add validation about effect method getting from `agent`.
+* [optimize] add validation about effect method getting from `agent`.
+
+# 4.2.5 2022-03-22
+
+* [bug] repair the problem about when all the connections from agents are disconnected, the method effect may still work, and change state, if it is a asynchronous method. 

docs/zh/changes.md

@@ -179,4 +179,8 @@
 
 # 4.2.4 2022-03-21
 
-* [optimize] 新增对通过 `agent` 获取 effect 修饰方法的非法校验。
+* [optimize] 新增对通过 `agent` 获取 effect 修饰方法的非法校验。
+
+# 4.2.5 2022-03-22
+
+* [bug] 修复异步副作用方法在所有代理断连后，依然可以修改 state 的问题。

package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-reducer",
-  "version": "4.2.4",
+  "version": "4.2.5",
   "main": "dist/agent-reducer.mini.js",
   "typings": "index.d.ts",
   "author": "Jimmy.Harding",

src/libs/effect.ts

@@ -101,6 +101,9 @@ function createEffect<S=any, T extends Model<S> = Model>(
 }
 
 export function runningNotInitialedModelEffects<S=any, T extends Model<S> = Model>(model:T):void {
+  if (!isConnecting<S, T>(model)) {
+    return;
+  }
   const effects = model[agentEffectsKey] || [];
   const notInitialedModelEffects = effects.filter(
     (effect) => !effect.initialed,

src/libs/reducer.ts

@@ -231,7 +231,7 @@ function createMethodEffectBuilder<
     T extends Model<S>= Model<S>
     >(entity:T) {
   return function methodEffectBuilder(effectMethod:EffectMethod<S, T>, args:any[]) {
-    return connect<S, T>(entity).run((ag) => effectMethod.apply(ag, args));
+    return connect<S, T>(entity).run((ag) => { effectMethod.apply(ag, args); });
   };
 }
 

test/guard/effect.test.ts

@@ -1,4 +1,4 @@
-import {addEffect, create} from "../../src";
+import {addEffect, create, effect} from "../../src";
 import {EffectCallback, Model} from "../../src/libs/global.type";
 import {agentEffectsKey} from "../../src/libs/defines";
 
@@ -214,4 +214,72 @@ describe("the trigger time about effect", () => {
         expect(()=>addEffect(effectCallback, model, model.decrease)).toThrow();
     });
 
+});
+
+describe('async effect',()=>{
+
+    type User = {
+        id:number|null,
+        username:string|null,
+        password:string|null,
+        nick:string,
+        name?:string,
+        sex?:'male'|'female',
+        age?:number
+    };
+
+    class UserModel implements Model<User>{
+
+        state:User = {
+            id:null,
+            username:null,
+            password:null,
+            nick:'guest'
+        };
+
+        login(username:string,password:string):User{
+            return {...this.state,id:null,username,password};
+        }
+
+        private initial(user:Omit<User,'password'>):User{
+            return {...user,password: null};
+        }
+
+        @effect(()=>UserModel.prototype.login)
+        private async fetchUser(){
+            const {username}=this.state;
+            const user:Omit<User,'password'> = await new Promise((resolve)=>setTimeout(()=>{
+                resolve({
+                    id:1,
+                    username,
+                    nick:'nick',
+                    name:'name',
+                    sex:'male'
+                });
+            }));
+            this.initial(user);
+        }
+
+    }
+
+    test('test disconnect before effect starts action',async ()=>{
+        const model = new UserModel();
+        const {agent,connect,disconnect} = create(model);
+        connect();
+        agent.login('user','xxx');
+        disconnect();
+        await new Promise(resolve => setTimeout(resolve));
+        expect(model.state.id).toBe(null);
+    });
+
+    test('test disconnect after effect starts action',async ()=>{
+        const model = new UserModel();
+        const {agent,connect,disconnect} = create(model);
+        connect();
+        agent.login('user','xxx');
+        await new Promise(resolve => setTimeout(resolve));
+        disconnect();
+        expect(model.state.id).toBe(1);
+    });
+
 });