Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code in tests/spec/fs.close.spec.js to use const/let and strict mode #658

Closed
OlenaVyshnevska opened this issue Jan 20, 2019 · 2 comments
Closed

Update code in tests/spec/fs.close.spec.js to use const/let and strict mode #658

OlenaVyshnevska opened this issue Jan 20, 2019 · 2 comments
Assignees
@OlenaVyshnevska

Comments

@OlenaVyshnevska
Copy link
Contributor

  • fs.close.spec.js file contains "var" variable declaration which should be substituted for let and const.

  • The file should implement strict mode
@humphd
Copy link
Contributor

humphd commented Jan 21, 2019

@OlenaVyshnevska sounds good to me, go for it. It's all yours.

@humphd
Copy link
Contributor

humphd commented Jan 31, 2019

In your PRs, you can tell GitHub to auto-close a bug by using "Fixes #658" in the PR description.

@humphd humphd closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlenaVyshnevska OlenaVyshnevska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humphd @OlenaVyshnevska