Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code in tests/spec/fs.close.spec.js to use const/let and strict mode #658

Closed
OlenaVyshnevska opened this Issue Jan 20, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@OlenaVyshnevska
Copy link
Contributor

OlenaVyshnevska commented Jan 20, 2019

  • fs.close.spec.js file contains "var" variable declaration which should be substituted for let and const.

  • The file should implement strict mode

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Jan 21, 2019

@OlenaVyshnevska sounds good to me, go for it. It's all yours.

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Jan 31, 2019

In your PRs, you can tell GitHub to auto-close a bug by using "Fixes #658" in the PR description.

@humphd humphd closed this Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.