fix #418 test for fsPromises.truncate(path[, len]) #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n length is negative
biskit1
suggested changes
Sep 28, 2018
| var fsPromises = util.fs().promises; | ||
| var contents = 'This is a file.'; | ||
|
|
||
| return fsPromises.writeFile('/myfile', contents) |
There was a problem hiding this comment.
Does this need to be a return @deepanjali19?
There was a problem hiding this comment.
It does, so that the containing test gets a Promise it can use to know when the test is complete. With callback based tests you don't need to; but with Promise based ones you do.
There was a problem hiding this comment.
Thank you @humphd for explaining it better than I could have.
|
@deepanjali19 this looks good, we just need to resolve this merge conflict. Let's do it in class tomorrow together. |
|
Sure @humphd ! |
|
Rebased and merged in 94fd5ba. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #418.
There is now a test available for fsPromises.truncate(path[, len]) .
It checks if the length of the file is negative, and sends an error message.