Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #544 - Test for fs.truncate() << test, when file does not exists #545

Closed
wants to merge 5 commits into from

Conversation

charBap
Copy link

@charBap charBap commented Oct 6, 2018

Added test to fs.truncate() that checks if a file does not exists.
I have used promises to test this out.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Can you please correct the styling issues I pointed out? Also, you've got a merge conflict with what's on master. We can fix that in class on Friday together. Just get your other changes committed and pushed before then.

tests/spec/fs.truncate.spec.js Show resolved Hide resolved
tests/spec/fs.truncate.spec.js Show resolved Hide resolved
tests/spec/fs.truncate.spec.js Outdated Show resolved Hide resolved
tests/spec/fs.truncate.spec.js Outdated Show resolved Hide resolved
@charBap
Copy link
Author

charBap commented Oct 10, 2018

I made all the changes that you pointed out. Thank you.

@humphd
Copy link
Contributor

humphd commented Dec 13, 2018

Looks like this same test was already added and is on master now. Closing.

@humphd humphd closed this Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants