Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #544 - Test for fs.truncate() << test, when file does not exists #545

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
2 participants
@charBap
Copy link

commented Oct 6, 2018

Added test to fs.truncate() that checks if a file does not exists.
I have used promises to test this out.

charBap added some commits Oct 6, 2018

@humphd
Copy link
Contributor

left a comment

Looks pretty good. Can you please correct the styling issues I pointed out? Also, you've got a merge conflict with what's on master. We can fix that in class on Friday together. Just get your other changes committed and pushed before then.

Show resolved Hide resolved tests/spec/fs.truncate.spec.js
Show resolved Hide resolved tests/spec/fs.truncate.spec.js
Show resolved Hide resolved tests/spec/fs.truncate.spec.js Outdated
Show resolved Hide resolved tests/spec/fs.truncate.spec.js Outdated
@charBap

This comment has been minimized.

Copy link
Author

commented Oct 10, 2018

I made all the changes that you pointed out. Thank you.

@humphd

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

Looks like this same test was already added and is on master now. Closing.

@humphd humphd closed this Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.