Removed vertical tab flyout (#9786)

files-community · Aug 21, 2022 · 3cf5671 · 3cf5671
1 parent a8d48f0
commit 3cf5671
Show file tree

Hide file tree

Showing 13 changed files with 451 additions and 1,665 deletions.
diff --git a/src/Files.Backend/Services/Settings/IMultitaskingSettingsService.cs b/src/Files.Backend/Services/Settings/IMultitaskingSettingsService.cs
@@ -4,10 +4,6 @@ namespace Files.Backend.Services.Settings
 {
     public interface IMultitaskingSettingsService : IBaseSettingsService, INotifyPropertyChanged
     {
-        /// <summary>
-        /// Gets or sets a value indicating whether or not to enable the vertical tab flyout.
-        /// </summary>
-        bool IsVerticalTabFlyoutEnabled { get; set; }
 
         /// <summary>
         /// Gets or sets a value indicating whether or not to enable dual pane feature.

diff --git a/src/Files.Uwp/Files.Uwp.csproj b/src/Files.Uwp/Files.Uwp.csproj
@@ -542,9 +542,6 @@
       <DependentUpon>OngoingTasksFlyout.xaml</DependentUpon>
     </Compile>
     <Compile Include="UserControls\MultitaskingControl\TabItem\TabItem.cs" />
-    <Compile Include="UserControls\MultitaskingControl\VerticalTabViewControl.xaml.cs">
-      <DependentUpon>VerticalTabViewControl.xaml</DependentUpon>
-    </Compile>
     <Compile Include="UserControls\Widgets\DrivesWidget.xaml.cs">
       <DependentUpon>DrivesWidget.xaml</DependentUpon>
     </Compile>
@@ -1241,14 +1238,6 @@
       <SubType>Designer</SubType>
       <Generator>MSBuild:Compile</Generator>
     </Page>
-    <Page Include="ResourceDictionaries\TabViewItem_shared.xaml">
-      <SubType>Designer</SubType>
-      <Generator>MSBuild:Compile</Generator>
-    </Page>
-    <Page Include="ResourceDictionaries\TabView_vertical.xaml">
-      <SubType>Designer</SubType>
-      <Generator>MSBuild:Compile</Generator>
-    </Page>
     <Page Include="ResourceDictionaries\RightAlignedToggleSwitchStyle.xaml">
       <Generator>MSBuild:Compile</Generator>
       <SubType>Designer</SubType>
@@ -1397,10 +1386,6 @@
       <SubType>Designer</SubType>
       <Generator>MSBuild:Compile</Generator>
     </Page>
-    <Page Include="UserControls\MultitaskingControl\VerticalTabViewControl.xaml">
-      <SubType>Designer</SubType>
-      <Generator>MSBuild:Compile</Generator>
-    </Page>
     <Page Include="UserControls\Widgets\BundlesWidget.xaml">
       <SubType>Designer</SubType>
       <Generator>MSBuild:Compile</Generator>

diff --git a/src/Files.Uwp/ResourceDictionaries/TabViewItem_shared.xaml b/src/Files.Uwp/ResourceDictionaries/TabViewItem_shared.xaml
diff --git a/src/Files.Uwp/ResourceDictionaries/TabView_vertical.xaml b/src/Files.Uwp/ResourceDictionaries/TabView_vertical.xaml
diff --git a/src/Files.Uwp/ServicesImplementation/Settings/MultitaskingSettingsService.cs b/src/Files.Uwp/ServicesImplementation/Settings/MultitaskingSettingsService.cs
@@ -13,12 +13,6 @@ public MultitaskingSettingsService(ISettingsSharingContext settingsSharingContex
             RegisterSettingsContext(settingsSharingContext);
         }
 
-        public bool IsVerticalTabFlyoutEnabled
-        {
-            get => Get(true);
-            set => Set(value);
-        }
-
         public bool IsDualPaneEnabled
         {
             get => Get(false);
@@ -35,7 +29,6 @@ protected override void RaiseOnSettingChangedEvent(object sender, SettingChanged
         {
             switch (e.SettingName)
             {
-                case nameof(IsVerticalTabFlyoutEnabled):
                 case nameof(IsDualPaneEnabled):
                 case nameof(AlwaysOpenDualPaneInNewTab):
                     Analytics.TrackEvent($"{e.SettingName} {e.NewValue}");
@@ -47,7 +40,6 @@ protected override void RaiseOnSettingChangedEvent(object sender, SettingChanged
 
         public void ReportToAppCenter()
         {
-            Analytics.TrackEvent($"{nameof(IsVerticalTabFlyoutEnabled)}, {IsVerticalTabFlyoutEnabled}");
             Analytics.TrackEvent($"{nameof(IsDualPaneEnabled)}, {IsDualPaneEnabled}");
             Analytics.TrackEvent($"{nameof(AlwaysOpenDualPaneInNewTab)}, {AlwaysOpenDualPaneInNewTab}");
         }

diff --git a/src/Files.Uwp/Strings/en-US/Resources.resw b/src/Files.Uwp/Strings/en-US/Resources.resw
@@ -810,12 +810,6 @@
   <data name="NavUpButton.AutomationProperties.Name" xml:space="preserve">
     <value>Go up one directory</value>
   </data>
-  <data name="VerticalTabFlyout.AutomationProperties.Name" xml:space="preserve">
-    <value>Vertical tab flyout</value>
-  </data>
-  <data name="VerticalTabFlyout.ToolTipService.ToolTip" xml:space="preserve">
-    <value>Vertical tab flyout</value>
-  </data>
   <data name="SettingsPreferencesAppLanguage.Title" xml:space="preserve">
     <value>Language</value>
   </data>
@@ -2013,9 +2007,6 @@
   <data name="SecurityUnknownOwnerText.Text" xml:space="preserve">
     <value>Unknown owner</value>
   </data>
-  <data name="SettingsVerticalTabFlyout" xml:space="preserve">
-    <value>Display the vertical tab flyout on the title bar</value>
-  </data>
   <data name="SettingsThemesLearnMoreButton.AutomationProperties.Name" xml:space="preserve">
     <value>Learn more about custom themes</value>
   </data>

diff --git a/src/Files.Uwp/UserControls/MultitaskingControl/TabItem/TabItemControl.xaml b/src/Files.Uwp/UserControls/MultitaskingControl/TabItem/TabItemControl.xaml
@@ -1,18 +1,18 @@
 <UserControl
-    x:Class="Files.Uwp.UserControls.MultitaskingControl.TabItemControl"
-    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
-    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
-    xmlns:local="using:Files.Uwp.UserControls.MultitaskingControl"
-    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
-    d:DesignHeight="300"
-    d:DesignWidth="400"
-    mc:Ignorable="d">
+	x:Class="Files.Uwp.UserControls.MultitaskingControl.TabItemControl"
+	xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+	xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+	xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
+	xmlns:local="using:Files.Uwp.UserControls.MultitaskingControl"
+	xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+	d:DesignHeight="300"
+	d:DesignWidth="400"
+	mc:Ignorable="d">
 
-    <Frame
-        x:Name="ContentFrame"
-        Background="Transparent"
-        CacheSize="0"
-        IsNavigationStackEnabled="False"
-        Navigated="ContentFrame_Navigated" />
+	<Frame
+		x:Name="ContentFrame"
+		Background="Transparent"
+		CacheSize="0"
+		IsNavigationStackEnabled="False"
+		Navigated="ContentFrame_Navigated" />
 </UserControl>
diff --git a/src/Files.Uwp/UserControls/MultitaskingControl/VerticalTabViewControl.xaml b/src/Files.Uwp/UserControls/MultitaskingControl/VerticalTabViewControl.xaml