Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improving the recycle bin experience #1089

Closed
2 of 4 tasks
yaira2 opened this issue Jun 17, 2020 · 23 comments
Closed
2 of 4 tasks

Feature: Improving the recycle bin experience #1089

yaira2 opened this issue Jun 17, 2020 · 23 comments

Comments

@yaira2
Copy link
Member

yaira2 commented Jun 17, 2020

@ghost ghost added the needs-triage label Jun 17, 2020
@yaira2 yaira2 pinned this issue Jun 17, 2020
@yaira2 yaira2 unpinned this issue Jun 17, 2020
@SOI7
Copy link

SOI7 commented Jun 17, 2020

Apart from the obvious need of an Empty Bin and a Restore File function, one grip I have with the Recycle Bin atm is that it gets lost inside the libraries tree, and since it's not a regular folder, it should be inside a separated area, maybe either like the Drives section or ditching the library layout and use it as a simple button somewhere

@gave92
Copy link
Member

gave92 commented Jun 17, 2020

Thanks for the feedback.
Both "Empty Bin" and "Restore File" functions are already available (through right click context menu, if they are not there it's a bug).
After the latest modifications the recycle bin link on the sidebar will appear as the second item (right after the quick access/home link) but this can problably be improved 👍

@Richard-HM
Copy link
Contributor

Richard-HM commented Jun 17, 2020

  • I think an option to empty the recycle bin from the sidebar
  • And maybe disable "properties" from the context menu, because it doesn't show anything useful about the recycle bin.

when you enable the recycle bin, it appears under "videos" in the sidebar, but when you reopen the app, it appears under "home", is this ok?

@gave92
Copy link
Member

gave92 commented Jun 17, 2020

@xpoppyx perhaps a "empty bin" button on the topbar would be better? Like instead of the disabled "plus" button.

You're right the recycle bin changing position on the sidebar is not ok. I guess it should either be always at the bottom or in a separate section.

@Richard-HM
Copy link
Contributor

perhaps a "empty bin" button on the topbar would be better? Like instead of the disabled "plus" button.

I want to avoid having to open the recycle bin first to be able to empty

@gave92
Copy link
Member

gave92 commented Jun 17, 2020

I see, so perhaps an option to emtpy the bin when you right click on the recycle bin entry on the sidebar

@SOI7
Copy link

SOI7 commented Jun 18, 2020

Recycle bin could also use different icons for when it's empty or not. Also, right now I need to refresh it to see changes after emptying it

@Richard-HM
Copy link
Contributor

I was testing file restoration, and all are restored without extension

when it is deleted:
Anotación 2020-06-28 090022

after restoring:
Anotación 2020-06-28 090100

@tsvietOK
Copy link
Contributor

@xpoppyx Can't reproduce, v0.11

@Richard-HM
Copy link
Contributor

restore

@stamminator
Copy link

stamminator commented Jul 1, 2020

  • And maybe disable "properties" from the context menu, because it doesn't show anything useful about the recycle bin.

I agree. In fact, in my version (v0.11.0.0, Windows 10 2004 19041.329), selecting "properties" causes the entire app to crash. I didn't submit a bug report because @xpoppyx's suggestion would render it moot.

@gave92
Copy link
Member

gave92 commented Jul 1, 2020

@stamminator Properties menu for recycle bin was recently removed (in #1264) 👍

@ericcornelissen
Copy link

perhaps a "empty bin" button on the topbar would be better? Like instead of the disabled "plus" button.

I want to avoid having to open the recycle bin first to be able to empty

I would still like to see a button in the top bar to empty the recycle bin to be honest, in addition to the option in the right-click menu.

@crashmit
Copy link

Would it be possible to also put in a "Date Deleted" category? The Date Modified usually doesn't help there and I mostly restore items, I deleted recently. Would improve UX a lot for me to be able to sort by "Date Deleted"

@yaira2
Copy link
Member Author

yaira2 commented Jan 10, 2021

Would it be possible to also put in a "Date Deleted" category? The Date Modified usually doesn't help there and I mostly restore items, I deleted recently. Would improve UX a lot for me to be able to sort by "Date Deleted"

This was just implemented with #2892.

@crashmit
Copy link

Oh perfect, thank you!

@mdtauk
Copy link

mdtauk commented Jan 10, 2021

Could the Recycle Bin be Pinned to the sidebar, maybe above the Settings at the bottom of the sidebar?

@KAMiKAZOW
Copy link

I want to avoid having to open the recycle bin first to be able to empty

A button in the toolbar would still be nice when I already have the trash open.

@lukeblevins
Copy link
Contributor

@yaichenbaum Wondering if there are any updates we can make to this issue's description. For instance, has the missing item extensions on restore bug been fixed?

@yaira2
Copy link
Member Author

yaira2 commented Apr 14, 2021

@duke7553 As of now, nothing has changed with the issue.

@BanCrash
Copy link
Contributor

In last commit version, when you enter on the empty recycle bin after one directory with files, it will show the account of files on the previous directory instead "0 items":

image

However, if you enter a non-empty recycle bin and after that, you clean it, it will show "0 items":

image

image

To reproduce:
1- Clean the recycle bin.
2- Go to another folder that has files inside.
3- Go back to the recycle bin. It will show the amount of items on the previous folder instead 0.

Version: Last commit
OS Version: 10.0.19043.1081

Logs:
debug_fulltrust.log
debug.log

@cinqmilleans
Copy link
Contributor

@yaichenbaum @gave92 @SOI7 @mdtauk @ericcornelissen @lukeblevins @Rick-HM @tsvietOK @stamminator @crashmit @KAMiKAZOW Here is a suggested placement of the Recycle Bin. It can be placed as a section between Home and Favorites.

  • The recycle bin always accessible even if the favorites are folded.
  • Highlights the recycle bin, which cannot be reached like a regular folder.
  • Doesn't take up more space than it currently does, unless the bookmarks are folded up.
  • The display of the recycle bin is no longer a specific option, but a section like the others, which can be displayed with the contextual menu of the sidebar.
  • It can increase clutter if the user has a lot of section.

What do you think ?

RecycleBin_Project

@yaira2
Copy link
Member Author

yaira2 commented Jul 10, 2022

I'm not a fan of that design, recycle bin should be treated the same as other favorites.

@yaira2 yaira2 closed this as completed Jul 10, 2022
@yaira2 yaira2 reopened this Jul 10, 2022
@yaira2 yaira2 changed the title Input needed: Improving the recycle bin experience Feature: Improving the recycle bin experience Sep 8, 2022
@yaira2 yaira2 closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests