Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Display drive letter of the connected network drives #10269

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Oct 21, 2022

Resolved / Related Issues
The access path of network disks which have a local access path is not displayed in their label, contrary to fixed disks. This is so in the item name received by .net and FileExplorer has the same problem. This pr adds this missing path for consistency and readability
Closes #10261.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Before/After
Drive1
fix2
fix4
fix5

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 21, 2022
@yaira2 yaira2 changed the title Fix name for network drives Feature: Display drive letter of the connected network drives Oct 21, 2022
@yaira2 yaira2 merged commit edcf62b into files-community:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Display drive letter of the connected network drives
2 participants