Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed crash that would occur when updating from the store #10795

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Fix: Fixed crash that would occur when updating from the store #10795

merged 2 commits into from
Dec 21, 2022

Conversation

puppetsw
Copy link
Contributor

@puppetsw puppetsw commented Dec 21, 2022 •
edited

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Fixes issue with store versions crashing when trying to show store update dialog window.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@puppetsw puppetsw changed the title FIX: Store Update Crash Fix: Store Update Crash Dec 21, 2022
@yaira2 yaira2 changed the title Fix: Store Update Crash Fix: Fixed crash that would occur when updating from the store Dec 21, 2022
yaira2
yaira2 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 21, 2022
@yaira2 yaira2 merged commit ac1160f into files-community:main Dec 21, 2022
@QuaintMako QuaintMako mentioned this pull request Dec 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 left review comments

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puppetsw @gave92 @yaira2